[PATCH] D62443: [WebAssembly] Move Emscripten-specific behavior under a --emscripten flag

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 15:55:40 PDT 2019


sbc100 added a comment.

Wouldn't it be better to try to avoid adding a `--emscripten`?

I think for __heap_base/__data_end we should change emscripten to export them explicitly.  (I'll look into doing that).

Once we do that then this change only removes the `-pie` `-shared` behaviour, right?



================
Comment at: docs/WebAssembly.rst:135
+and symbols marked with ``__attribute__((used))`` are also exported from
+the WebAssembly module.
 
----------------
The ``__attribute__((used))`` behaviour is depend on the compiler time triple isn't it ?  Not the linker flag?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62443/new/

https://reviews.llvm.org/D62443





More information about the llvm-commits mailing list