[PATCH] D62430: [PPC] Correctly adjust branch probability in PPCReduceCRLogicals

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 15:46:25 PDT 2019


xur added inline comments.


================
Comment at: lib/Target/PowerPC/PPCReduceCRLogicals.cpp:171
+  // It's impossible to know the precise branch probability after the split.
+  // But it still need to be reasonable, the whole probability to original
+  // targets should not be changed.
----------------
NIT: (1) "need" -> "needs".
(2) Please also explain what is P0, P1, P2.  A diagram would be helpful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62430/new/

https://reviews.llvm.org/D62430





More information about the llvm-commits mailing list