[PATCH] D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 15:39:21 PDT 2019


wmi added a comment.

In D62540#1520087 <https://reviews.llvm.org/D62540#1520087>, @davidxl wrote:

> what is the main blocker for the longer term solution?


Like Hal mentioned the symbol list may be large since it include all the symbols. Current autofdo profile only include symbols that are hot/warm, so the whole symbol list should be way larger than the symbol section in current autofdo profile. I havn't looked at whether bloom-filter can help here. If we use md5, we will have a problem on profile-remapping.(https://llvm.org/docs/CommandGuide/llvm-profdata.html#cmdoption-llvm-profdata-merge-remapping-file).

I don't see other blockers.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62540/new/

https://reviews.llvm.org/D62540





More information about the llvm-commits mailing list