[llvm] r361879 - AMDGPU: Temporary drop s_mul_hi_i/u32 patterns
Konstantin Zhuravlyov via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 14:18:34 PDT 2019
Author: kzhuravl
Date: Tue May 28 14:18:34 2019
New Revision: 361879
URL: http://llvm.org/viewvc/llvm-project?rev=361879&view=rev
Log:
AMDGPU: Temporary drop s_mul_hi_i/u32 patterns
It introduces performance regressions in several applications.
This has already been submitted downstream.
Modified:
llvm/trunk/lib/Target/AMDGPU/SOPInstructions.td
llvm/trunk/test/CodeGen/AMDGPU/mul.ll
Modified: llvm/trunk/lib/Target/AMDGPU/SOPInstructions.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/SOPInstructions.td?rev=361879&r1=361878&r2=361879&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/SOPInstructions.td (original)
+++ llvm/trunk/lib/Target/AMDGPU/SOPInstructions.td Tue May 28 14:18:34 2019
@@ -558,12 +558,8 @@ let SubtargetPredicate = isGFX9Plus in {
def S_LSHL4_ADD_U32 : SOP2_32<"s_lshl4_add_u32">;
} // End Defs = [SCC]
- let isCommutable = 1 in {
- def S_MUL_HI_U32 : SOP2_32<"s_mul_hi_u32",
- [(set i32:$sdst, (UniformBinFrag<mulhu> SSrc_b32:$src0, SSrc_b32:$src1))]>;
- def S_MUL_HI_I32 : SOP2_32<"s_mul_hi_i32",
- [(set i32:$sdst, (UniformBinFrag<mulhs> SSrc_b32:$src0, SSrc_b32:$src1))]>;
- }
+ def S_MUL_HI_U32 : SOP2_32<"s_mul_hi_u32">;
+ def S_MUL_HI_I32 : SOP2_32<"s_mul_hi_i32">;
} // End SubtargetPredicate = isGFX9Plus
//===----------------------------------------------------------------------===//
Modified: llvm/trunk/test/CodeGen/AMDGPU/mul.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AMDGPU/mul.ll?rev=361879&r1=361878&r2=361879&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AMDGPU/mul.ll (original)
+++ llvm/trunk/test/CodeGen/AMDGPU/mul.ll Tue May 28 14:18:34 2019
@@ -141,11 +141,6 @@ define amdgpu_kernel void @v_mul_i32(i32
; crash with a 'failed to select' error.
; FUNC-LABEL: {{^}}s_mul_i64:
-; GFX9_10-DAG: s_mul_i32
-; GFX9_10-DAG: s_mul_hi_u32
-; GFX9_10-DAG: s_mul_i32
-; GFX9_10-DAG: s_mul_i32
-; GFX9_10: s_endpgm
define amdgpu_kernel void @s_mul_i64(i64 addrspace(1)* %out, i64 %a, i64 %b) nounwind {
%mul = mul i64 %a, %b
store i64 %mul, i64 addrspace(1)* %out, align 8
More information about the llvm-commits
mailing list