[PATCH] D60095: [LLD][COFF] Early load PDB type server files

Tue May 28 14:04:37 PDT 2019

stella.stamenova added a comment.

I am not very familiar with the lldb-mi tests specifically, but it looks like they require python to run (and are marked as unsupported otherwise):

  # lldb-mi always fails without Python support
  if lldbmi.was_resolved and not config.lldb_disable_python:
      config.available_features.add('lldb-mi')

My guess is that the different comes from the options you passed to cmake at configuration time. This is what the Buildbot does:

  cmake -G Ninja ../llvm -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../install -DPYTHON_HOME="C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64" -DLLVM_ENABLE_ASSERTIONS=OFF

On Windows, I've noticed that if we don't correctly configure PYTHON_HOME, there are a variety of issues that pop up.

In D60095#1519986 <https://reviews.llvm.org/D60095#1519986>, @aganea wrote:

> @stella.stamenova : I'll have to revert it, I'm not sure what's going on. When I run the tests on my Windows PC, many tests are tagged as 'unsupported', I don't know why:
>
>   Unsupported Tests  : 796
>
>
> Whereas on your build bot, there are no 'unsupported' tests:
>
>   Expected Passes    : 1596
>   Expected Failures  : 11
>   Unsupported Tests  : 46
>   
>
> If I try to manually run the test that fails on the bot: `C:\Users\aganea\AppData\Local\Programs\Python\Python37-32\python.exe F:/svn/buildninja/./bin/llvm-lit.py -sv -vv -a F:\svn\lldb\lit\tools\lldb-mi\exec\exec-finish.test`, I also get:
>
>   UNSUPPORTED: LLDB :: tools/lldb-mi/exec/exec-finish.test (1 of 1)
>   Test is unsupported
>
>
> If I run the commands in the test manually, I get to a point where lldb-mi doesn't want to run:
>
>   F:\svn\buildninja\tools\lldb\lit>f:\svn\buildninja\bin\lldb-mi.exe
>   MI: Error: Driver. LLDB Debugger.
>   MI: Error: Driver Manager. Driver 'Machine Interface Driver Version: 1.0.0.9' (ID:'MIDriver') initialise failed. Driver. LLDB Debugger.
>
>
> Any suggestions? I'll revert the patch in the meanwhile.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60095/new/

https://reviews.llvm.org/D60095