[PATCH] D62541: Adding a function for setting coverage output file.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 13:11:19 PDT 2019
efriedma added a comment.
It looks like this patch is exposing some new symbols which don't have an "__" prefix... do we have some formal policy about that for libclang_rt.profile? It's sort of orthogonal to this patch, though... lprofGetProfileFile and lprofSetProfileFile should probably be marked "static".
It looks like passing in a FILE* implicitly disables profile merging; is that intentional? If so, it should probably be documented somehow.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62541/new/
https://reviews.llvm.org/D62541
More information about the llvm-commits
mailing list