[PATCH] D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section

[Wei Mi via Phabricator via llvm-commits]

wmi created this revision.
wmi added reviewers: davidxl, danielcdh.
Herald added subscribers: kristof.beyls, eraman, javed.absar.
Herald added a project: LLVM.

For sampleFDO, because the optimized build uses profile generated from previous release, we cannot tell a function without profile is truely cold or just newly created. Currently we treat them conservatively and put them in .text section instead of .text.unlikely. The result is when we persuing the best performance by locking .text.hot and .text in memory, and use huge pages for them, we waste a lot of memory and huge pages for functions actually being cold.

We already have a related option called -profile-sample-accurate. If we uses that option, function without profile will be treated as cold and we won't have the memory/huge pages waste problem, but we are going to see performance problem if new functions actually being hot are treated as cold.

To mitigate the problem, we provide another option called --profile-unknown-in-special-section. For functions without profile, we will still treat them conservatively in compiler optimizations -- for example, treat them as warm instead of cold in inliner.  When we use profile info to add section prefix for functions, we will discriminate functions known to be not cold versus functions without profile (being unknown), and we will put functions being unknown in a special text section called .text.unknown. Runtime system will have the flexibility to decide where to put the special section in order to achieve a balance between performance and memory saving.


Repository:
  rL LLVM

https://reviews.llvm.org/D62540

Files:
  include/llvm/Analysis/ProfileSummaryInfo.h
  lib/Analysis/ProfileSummaryInfo.cpp
  lib/CodeGen/CodeGenPrepare.cpp
  lib/Transforms/Utils/SizeOpts.cpp
  test/Transforms/SampleProfile/section-accurate-samplepgo.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62540.201727.patch
Type: text/x-patch
Size: 6230 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190528/c02d7097/attachment.bin>