[PATCH] D61969: Fix Bugzilla ID 41862 to support checking addresses of disassembled object
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 10:05:26 PDT 2019
rupprecht added inline comments.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1407
+ if (StartAddress >= StopAddress)
+ error("error: start address should not be less than or equal to stop address");
----------------
The original error message is correct; the start should be less than the stop. The only issue was we didn't error when start == stop. Also, btw, the error message should automatically `error`, so adding it to the error string is redundant.
I'm fine with lower casing `Start` -> `start` though.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61969/new/
https://reviews.llvm.org/D61969
More information about the llvm-commits
mailing list