[PATCH] D62311: [LV] Inform about exactly reason of loop illegality

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 09:54:04 PDT 2019


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM. Please take a look at the remaining test nits before committing



================
Comment at: llvm/test/Transforms/LoopVectorize/legal_loop_config.ll:1
+; RUN: opt < %s -loop-vectorize -debug-only=loop-vectorize -S -disable-output 2>&1 | FileCheck %s
+; REQUIRES: asserts
----------------
nit: Maybe something like `loop-legality-checks.ll` would be a slightly more descriptive name.


================
Comment at: llvm/test/Transforms/LoopVectorize/legal_preheader_check.ll:1
-; RUN: opt < %s -loop-vectorize -debug -S -o /dev/null 2>&1 | FileCheck %s
 ; REQUIRES: asserts
----------------
maybe fold this test into `llvm/test/Transforms/LoopVectorize/legal_loop_config.ll`, it would make sense to have the legality checks in a test file together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62311/new/

https://reviews.llvm.org/D62311





More information about the llvm-commits mailing list