[PATCH] D61600: [DebugInfo] More precise variable range for stack locations
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 09:42:28 PDT 2019
aprantl accepted this revision.
aprantl added a comment.
LGTM. Have you tested the performance when compiling Clang with ASAN enabled to make sure we're not accidentally regressing because of the more thorough single-location check?
================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:364
+ ChangingRegs.test(CurElem->first) ||
+ FrameReg == CurElem->first)
clobberRegisterUses(RegVars, CurElem, DbgValues, LiveEntries,
----------------
personally I'd write this as `CurElem->first == FrameReg` not a big deal, though
================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.h:119
+ /// Offset in DebugLocs.
+ unsigned DebugLocListIndex = ~0u;
+ /// Single value location description.
----------------
NFC commit for later, make this `Optional<unsigned>`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61600/new/
https://reviews.llvm.org/D61600
More information about the llvm-commits
mailing list