[PATCH] D61975: [CodeGen] Fix hashing for MO_ExternalSymbol MachineOperands.
    Eli Friedman via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue May 28 09:20:01 PDT 2019
    
    
  
efriedma added a comment.
> Would it make sense to also add a test explicitly using llvm::hash_combine
Using llvm::hash_combine on what, exactly?
> as well as a negative test where hash code comparison fails for a literal and the same literal in a StringRef every time
You mean something like `ASSERT_NE(SymName1.data(), SymName2.data());`?
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61975/new/
https://reviews.llvm.org/D61975
    
    
More information about the llvm-commits
mailing list