[PATCH] D62507: [Dominators] PR42041: Skip nullpointer successors
Jakub Kuderski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 08:39:28 PDT 2019
kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.
Thanks, I think this is a much better solution than directly hacking on DomTreeBuilder.
Note that every time you ask DomTree about a `nullptr` CFG node, it understands it as a request for a virtual root. While now this should crash on forward dominators, you will get an actual tree node for a nullptr in postdominators. In the future, it may happen that forward dominators will also have a virtual root (for more efficient updates) and the users of clang CFG and dominators should be aware that not every CFG node (i.e., an unreachable successor) has a corresponding DomTreeNode.
CHANGES SINCE LAST ACTION
More information about the llvm-commits