[PATCH] D60353: ELF: Add basic partition data structures and behaviours.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 07:19:01 PDT 2019
ruiu accepted this revision.
ruiu added a comment.
LGTM
================
Comment at: lld/ELF/InputSection.h:78
+ unsigned : 1;
+
----------------
pcc wrote:
> ruiu wrote:
> > It's not clear to me why you needed a one bit padding here.
> I added a comment explaining why.
Why do you have to use a bitfield? Looks like you can use uint8_t instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60353/new/
https://reviews.llvm.org/D60353
More information about the llvm-commits
mailing list