[PATCH] D62408: [X86] Avoid SFB - Fix inconsistent codegen with/without debug info(2)

Chris Dawson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 28 07:06:56 PDT 2019

cdawson marked an inline comment as done.
cdawson added inline comments.

Comment at: llvm/lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp:345
        PBInst != E; ++PBInst) {
+    if (PBInst->isDebugInstr())
+      continue;
aprantl wrote:
> Do you perhapswant to use `isMetaInstruction()` here? There are other non-debug instructions (CFI for example) that you might want to ignore.
This seems like a good idea, though it would be inconsistent with D61680 where `skipDebugInstructionsBackward()` is used. I think there's a benefit to checking for meta instrs in both these cases, but as far as I can see there isn't an equivalent `skipMetaInstructionsBackward()`. Do you think it would be worth adding `skipMetaInstructionsBackward/Forward()` and amending D61680? Or should I follow your proposed change only in this case.



More information about the llvm-commits mailing list