[PATCH] D62507: [Dominators] PR42041: Skip nullpointer successors
Kristóf Umann via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 06:17:55 PDT 2019
Szelethus planned changes to this revision.
Szelethus marked an inline comment as done.
Szelethus added inline comments.
Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:242
+ // unreachable), skip them.
+ if (!Succ)
> I hope we can find an approach that doesn't need the defensive check here. In post dominator tree nullptr represents the virtual root, this check will cause some confusion. I also don't know if a simple check here is sufficient, I guess somewhere else might need similar checks.
Yup, this isn't a good approach then. Thanks!
CHANGES SINCE LAST ACTION
More information about the llvm-commits