[PATCH] D62513: [ELF] Implement General Dynamic style x86-64 TLSDESC

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/X86_64.cpp:203
+    //   call *(%rax)
+    // to
+    assert(Type == R_X86_64_GOTPC32_TLSDESC);
----------------
missing comment?


================
Comment at: ELF/Arch/X86_64.cpp:210
+    }
+    // movq $x at tpoff(%rip),%rax
+    Loc[-2] = 0xc7;
----------------
Hm, it's not missing, but a sentence in a comment separated by code looks odd. I don't think we need to save a few lines. You can just repeat the same comments, one at the top of this block and the other inline.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62513/new/

https://reviews.llvm.org/D62513