[PATCH] D62480: gn build: make clangd depend on clang resource headers
Ilya Biryukov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 28 01:48:56 PDT 2019
ilya-biryukov added a comment.
The dependency is there in CMake, although it took me awhile to dig it out for first time.
It is added by `add_clang_tool`, see AddClang.cmake <https://github.com/llvm/llvm-project/blob/7d9cac5bbac26bed73b7dc4ab6c5815d8aa60b68/clang/cmake/modules/AddClang.cmake#L146>.
Obviously, we want the same dependency on other instances of `add_clang_tool`. The lack of this dependency can only be noticed when building a tool in a clean build directory **without** building clang. Worse yet, it will build just fine, but would fail to find the builtin headers at runtime.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62480/new/
https://reviews.llvm.org/D62480
More information about the llvm-commits
mailing list