[PATCH] D62445: [test] Fix plugin tests

[Don Hinton via Phabricator via llvm-commits]

hintonda marked an inline comment as done.
hintonda added inline comments.


================
Comment at: clang/test/CMakeLists.txt:141-147
-  if (LLVM_WITH_Z3)
-    add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver"
-      ${CMAKE_CURRENT_BINARY_DIR}/Analysis
-      PARAMS ${ANALYZER_TEST_PARAMS_Z3}
-      DEPENDS ${CLANG_TEST_DEPS})
-    set_target_properties(check-clang-analyzer-z3 PROPERTIES FOLDER "Clang tests")
   endif()
----------------
hintonda wrote:
> NoQ wrote:
> > As far as i remember, this chunk of code is responsible for running the whole analyzer test suite with different parameters (with Z3 as a constraint manager instead of the ad-hoc range constraint manager), rather than running a smaller chunk of the suite.
> > 
> > @mikhail.ramalho, @ddcc - i think i should leave it up to you to decide if you want to keep this working. Right now these extra tests aren't run under any buildbot, and the facility that they're testing is probably never going to be used by actual users (as opposed to the z3 refutation). But i wouldn't love losing this facility because it's a great way of evaluating the static analyzer, i.e. figuring out how good *could* it have been with a good constraint solver, so that we had something to look forward to.
> Ah, that was unintentional.  I didn't intend to touch Z3.
> 
> Let me see if I can put that part back.
Actually, on second thought, these get picked up automatically, so they shouldn't be added like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62445/new/

https://reviews.llvm.org/D62445