[PATCH] D62445: [test] Fix plugin tests

Artem Dergachev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 21:02:16 PDT 2019

NoQ added subscribers: mikhail.ramalho, ddcc.
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.


I think we're losing the Z3 constraint manager test suite this way after all (details inline), but i feel we should downprioritize this when it comes to fixing everybody's buildbots.

Comment at: clang/test/CMakeLists.txt:141-147
-  if (LLVM_WITH_Z3)
-    add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver"
-    set_target_properties(check-clang-analyzer-z3 PROPERTIES FOLDER "Clang tests")
As far as i remember, this chunk of code is responsible for running the whole analyzer test suite with different parameters (with Z3 as a constraint manager instead of the ad-hoc range constraint manager), rather than running a smaller chunk of the suite.

@mikhail.ramalho, @ddcc - i think i should leave it up to you to decide if you want to keep this working. Right now these extra tests aren't run under any buildbot, and the facility that they're testing is probably never going to be used by actual users (as opposed to the z3 refutation). But i wouldn't love losing this facility because it's a great way of evaluating the static analyzer, i.e. figuring out how good *could* it have been with a good constraint solver, so that we had something to look forward to.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list