[PATCH] D62126: [CorrelatedValuePropagation] Fix prof branch_weights metadata handling for SwitchInst
Yevgeny Rouban via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 27 20:55:46 PDT 2019
yrouban added a comment.
In D62126#1518460 <https://reviews.llvm.org/D62126#1518460>, @nikic wrote:
>
I considered this way and found it error prone. The wrapper stays alive after ConstantFoldTerminator() and developer may accidentally reuse it but the stored weights might be unsync with the underlying SwitchInst's weights changed by ConstantFoldTerminator().
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62126/new/
https://reviews.llvm.org/D62126
More information about the llvm-commits
mailing list