[PATCH] D62498: [x86] split 256-bit store of concatenated vectors

Mon May 27 16:57:28 PDT 2019

spatel added a comment.

In D62498#1518572 <https://reviews.llvm.org/D62498#1518572>, @spatel wrote:

> In D62498#1518518 <https://reviews.llvm.org/D62498#1518518>, @lebedev.ri wrote:
>
> > Can we ever happen to get volatile/atomic stores here?
>
>
> Good question - I didn't think about those. We have an ISD::ATOMIC_STORE node type, so that means we can rule out atomics? The existing split transform intended for SandyBridge doesn't appear to check for volatile either, so we might have an existing bug. I'll see if there's any test coverage for these cases.

I'm not too familiar with these modifiers, but atomic vector store looks forbidden:
"atomic store operand must have integer, pointer, or floating point type!"

We do have what appears to be an existing bug for volatile:
rL361785 <https://reviews.llvm.org/rL361785>

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62498/new/

https://reviews.llvm.org/D62498