[PATCH] D60047: [CaptureTracking] Don't let comparisons against null escape inbounds pointers

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 12:41:37 PDT 2019


jdoerfert accepted this revision.
jdoerfert added a comment.

LGTM.

I think @sanjoy was also happy with the argumentation so this is only blocked by D61607 <https://reviews.llvm.org/D61607> now.



================
Comment at: lib/Analysis/CaptureTracking.cpp:341
             break;
+        auto *O = I->getOperand(0)->stripPointerCasts();
+        if (!I->getFunction()->nullPointerIsDefined()) {
----------------
Make this `->stripPointerCastsSameRepresentation()` after D61607 landed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60047/new/

https://reviews.llvm.org/D60047





More information about the llvm-commits mailing list