[PATCH] D62062: [DWARF][RISCV] Add support for RISC-V relocations needed for debug info

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 11:05:03 PDT 2019


luismarques updated this revision to Diff 201552.
luismarques added a comment.

- The test dumps the relocations using llvm-readobj instead of llvm-objdump.
- Changes the `objdump` flag, from `-source` to `--source`.

@MaskRay  I had already patched, built and tested LLD against this patch, but the LLD changes were not included in this patch because LLD was checked-out as a separate repo. It's just a ctor change, as seen bellow. I can't update that right now, as I'm on the move. If you think it's necessary I will update the Phabricator patch to also include those changes for official review, at a later date.

  diff --git a/ELF/DWARF.cpp b/ELF/DWARF.cpp
  index 6b90a038e..e8310a48a 100644
  --- a/ELF/DWARF.cpp
  +++ b/ELF/DWARF.cpp
  @@ -110,8 +110,9 @@ LLDDwarfObj<ELFT>::findAux(const InputSectionBase &Sec, uint64_t Pos,
   
     DataRefImpl D;
     D.p = getAddend<ELFT>(Rel);
  -  return RelocAddrEntry{SecIndex, RelocationRef(D, nullptr),
  -                        LLDRelocationResolver<RelTy>::Resolve, Val};
  +  return RelocAddrEntry{SecIndex, RelocationRef(D, nullptr), Val,
  +                        Optional<object::RelocationRef>(), 0,
  +                        LLDRelocationResolver<RelTy>::Resolve};
   }


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62062/new/

https://reviews.llvm.org/D62062

Files:
  include/llvm/DebugInfo/DWARF/DWARFRelocMap.h
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFDataExtractor.cpp
  lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  lib/DebugInfo/DWARF/DWARFFormValue.cpp
  lib/DebugInfo/DWARF/DWARFListTable.cpp
  lib/DebugInfo/DWARF/DWARFUnit.cpp
  lib/Object/RelocationResolver.cpp
  test/DebugInfo/RISCV/dwarf-riscv-relocs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62062.201552.patch
Type: text/x-patch
Size: 14355 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190527/372a5004/attachment-0001.bin>


More information about the llvm-commits mailing list