[PATCH] D62424: Tests for nosync function attribute.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 11:05:02 PDT 2019

jdoerfert added inline comments.

Comment at: llvm/test/Transforms/FunctionAttrs/nosync.ll:70
+; CHECK: define i32 @load_acquire(i32* nocapture readonly) norecurse nounwind uwtable
+define i32 @bar(i32* nocapture readonly) norecurse nounwind uwtable {
Add a
`CHECK-NOT: nosync`
after the check line because you could otherwise have `nosync` at the end and pass anyway.

Comment at: llvm/test/Transforms/FunctionAttrs/nosync.ll:116
+; CHECK: define void @call_nosync_function() noinline nounwind readnone uwtable nosync
+define void @call_nosync_function() nounwind uwtable noinline {
FIXME: nosync missing
instead of nosync in the attribute list

We should be able to pass the test right now so we can integrate it already.
To this end, please also use the string attribute syntax `"nosync"` which should be accepted right now. (You can run lit on the test)

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list