[PATCH] D62249: RegAllocFast: Set MayLiveAcrossBlocks when allocating uses

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 09:13:45 PDT 2019

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Nitpicks on the test below.

Comment at: lib/CodeGen/RegAllocFast.cpp:310
+  return false;
arsenm wrote:
> qcolombet wrote:
> > Refactoring suggestion:
> > Use the same base code for both live-in and live-out the difference being:
> > 1. The returned value for early exits (pred_empty vs such_empty)
> > 2. The list we iterate on (defs vs uses)
> I tried this, but largely due to the return inside the block, it gets pretty ugly
Thanks for trying.

Comment at: test/CodeGen/X86/bug41973.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=x86_64-grtev4-linux-gnu -run-pass=regallocfast -o - %s | FileCheck %s
Could you give a more descriptive name (regalloc-fast-missing-live-out-spill) to the file and list the PR number in the test?
Also add a description of what are the characteristic of the test (use appears before def in different blocks).



More information about the llvm-commits mailing list