[PATCH] D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files.

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

In D62353#1518195 <https://reviews.llvm.org/D62353#1518195>, @hintonda wrote:

> I’m not sure printing out the entire CMakeCache.txt file is a good idea — it’s huge and much of it is of no interest.
>
> However, a subset including all the project specific variables would be great.  The good, or bad, depending on your perspective, is that the cache file isn’t available until processing is complete.  So we’d still need to iterate over all variables as a last step in say llvm/CMakeLists.txt.
>
> Perhaps noting default value and whether or not it’s in the cache.  To facilitate that, I’d like to try to wrap option in llvm_option and save the default to the cache as well.  This would also make it easy for maintainers to do the right thing and remove a lot of boilerplate from the cmake files.


I didn't mean to print that as a part of the normal configure step. That would definitely be too much information. I was thinking doing something on the buildbot side. I'm not sure how, but it seems like it is possible to attach arbitrary text nodes to each buildbot step (that's what our "WarningCountingShellCommand" does to create a link with all compiler warnings). I was thinking we could attach the cache file as a one of these nodes to the "cmake" step. That way people could open it if needed. 99% percent of the time you can just ignore it, but if you need it, the info is there...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62353/new/

https://reviews.llvm.org/D62353