[PATCH] D62443: [WebAssembly] Move Emscripten-specific behavior under a --emscripten flag

Mon May 27 05:59:32 PDT 2019

sunfish added a comment.

In D62443#1517831 <https://reviews.llvm.org/D62443#1517831>, @carlokok wrote:

> imo export-dynamic should still work? All it does it export all symbols that are linked in. My compiler uses and depends on that feature (though I can add emscripten as a flag to the linker, I don't think I should).

Can you use `--export-all` instead of `--export-dynamic`? On other platforms `--export-dynamic` exports symbols in the dynamic symbol table, which is not something that wasm has currently. When we do design dynamic linking for wasm, we may have a need for an option like `--export-dynamic`, and it would be unfortunate if it already means something different.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62443/new/

https://reviews.llvm.org/D62443