[PATCH] D61600: [DebugInfo] More precise variable range for stack locations

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 27 04:31:48 PDT 2019

dstenb added a comment.

Thanks a lot! This "location list -> single location description" detection seems more robust, and should help us moving towards supporting rewrites of single-entry location lists containing fragments also.

Nit: Perhaps we should move the Value class out of DebugLocEntry now that we use it for DbgVariable also? However, I don't have any good ideas on in where to place it (e.g. which header file). I think we can land this without doing such a refactoring though.

Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.h:114
 /// location changes over time use \a DebugLocListIndex, while those with a
-/// single instruction use \a MInsn and (optionally) a single entry of \a Expr.
+/// single instruction use \a ValueLoc and (optionally) a single entry of \a Expr.
Nit: Perhaps change //single instruction// -> //single location//?



More information about the llvm-commits mailing list