[PATCH] D62462: [llvm-objdump] Add warning messages if disassembly + source for problematic inputs

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

Generally looks good to me (with 2 nits), please wait for other opinions too.



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:560
+        warn(Twine("failed to find source " + LineInfo.FileName));
       return false;
+    }
----------------
I'd simplify:


```
      if (MissingSources.insert(LineInfo.FileName).second)
        warn("failed to find source " + LineInfo.FileName);
```


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:596
+    if(!WarnedNoDebugInfo) {
+      warn(Twine("failed to parse debug info which may be missing"));
+      WarnedNoDebugInfo = true;
----------------
You do not need `Twine(` here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62462/new/

https://reviews.llvm.org/D62462