[PATCH] D62153: [WebAssembly] Relax signature checking for undefined functions that are not called directly
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 27 03:14:14 PDT 2019
ruiu added inline comments.
================
Comment at: lld/trunk/wasm/InputFiles.h:78
+ // See https://bugs.llvm.org/show_bug.cgi?id=40412
+ std::vector<bool> SymbolIsCalledDirectly;
----------------
I'm not sure if I understand the code correctly. It seems like a bit indicating whether a symbol is called directly or not should logically belong to each Symbol object rather than a side table inside a file object, no? Let's say one file contains an undefined symbol, the other file contains a defined symbol, and the undefined symbol is called directly. If the linker merges the two symbols, the _defined_ symbol is called directly, isn't it?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62153/new/
https://reviews.llvm.org/D62153
More information about the llvm-commits
mailing list