[PATCH] D60047: [CaptureTracking] Don't let comparisons against null escape inbounds pointers

[Ayke via Phabricator via llvm-commits]

aykevl added a comment.

I think I have addressed all review comments (except for `stripPointerCasts` which is waiting on D61607 <https://reviews.llvm.org/D61607> and should hopefully land soon).

> @aykevl If you address the inline comments you can probably commit and close this review if you want. The special cases you encoded seem to be sound. If you want you can also generalize the patch and we review that version again. Please let me know what you intend to do.

This special case was a bad regression in my compiler after implementing some safety features required by the Go spec (in a way that does not rely on a MMU) so from my perspective it's done and can be committed (after `stripPointerCasts`). An old version of this patch caught all the missed optimizations and I'm pretty sure the current patch will do so as well. But if you have ideas how I can generalize this feature in a way that is non-controversial I can certainly do that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60047/new/

https://reviews.llvm.org/D60047