[PATCH] D62463: [ValueTracking][ConstantRange] Distinguish low/high always overflow
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun May 26 12:33:33 PDT 2019
lebedev.ri added inline comments.
================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:416
+ enum class OverflowResult {
+ AlwaysOverflowsLow, AlwaysOverflowsHigh, MayOverflow, NeverOverflows
+ };
----------------
These now need a comment for each.
While with the enum on the LHS of the diff it is obvious,
here i'm not sure what low/high means.
The direction of the overflow?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62463/new/
https://reviews.llvm.org/D62463
More information about the llvm-commits
mailing list