[PATCH] D61975: [CodeGen] Fix hashing for MO_ExternalSymbol MachineOperands.
Kristina Brooks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 25 02:25:25 PDT 2019
kristina added a comment.
Seems good. Would it make sense to also add a test explicitly using `llvm::hash_combine`, as well as a negative test where hash code comparison fails for a literal and the same literal in a `StringRef` every time (if it's possible to do reliably)? Just a random suggestion, probably overly paranoid.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61975/new/
https://reviews.llvm.org/D61975
More information about the llvm-commits
mailing list