[PATCH] D58804: AMDGPU/GlobalISel: Implement select for 32-bit G_ADD

[Tom Stellard via Phabricator via llvm-commits]

tstellar marked an inline comment as done.
tstellar added inline comments.


================
Comment at: test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir:40
+
+...
----------------
arsenm wrote:
> tstellar wrote:
> > arsenm wrote:
> > > 64-bit scalar at least looks like is already handled that should have a test here
> > Where did you see this?  I tried to add the test, but it complained that 64-bit G_ADD was not legal.
> bool AMDGPUInstructionSelector::selectG_ADD(MachineInstr &I) const {
> Creates an S_ADD_U32 + S_ADDC_U32 pair
Because 64-bit G_ADD is not legal yet, this code is only ever called when selecting G_GEP.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58804/new/

https://reviews.llvm.org/D58804