[PATCH] D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added a comment.

There are still unaddressed comments.



================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:111
+  if (SymEntPtr->StorageClass & 0x80)
+    StringRef("Unimplemented Debug Name"); 
+  uint32_t Offset = SymEntPtr->NameInStrTbl.Offset;
----------------
hubert.reinterpretcast wrote:
> Missing "`return`".
Please fix this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61532/new/

https://reviews.llvm.org/D61532