[PATCH] D62422: [COFF] Add ImportChunkThunk, simplify, deduplicate

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: lld/COFF/Chunks.h:177
 protected:
-  NonSectionChunk() : Chunk(OtherKind) {}
+  NonSectionChunk(Kind K = OtherKind) : Chunk(K) {}
 };
----------------
aganea wrote:
> Not a big deal, you could have said `using Chunk::Chunk` to not duplicate the behavior.
NVM, `using Base::Base` [[ https://stackoverflow.com/questions/31672057/why-shouldnt-the-inherited-constructor-inherit-the-default-arguments | doesn't ]] inherit default args.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62422/new/

https://reviews.llvm.org/D62422