[PATCH] D62347: [Support] Modernize process launching API

[Alexandre Ganea via Phabricator via llvm-commits]

aganea marked 5 inline comments as done.
aganea added a comment.

In D62347#1516136 <https://reviews.llvm.org/D62347#1516136>, @thakis wrote:

> The "modernized" api is a good chunk wordier. Can you outline how composing launching would look like with and without this change?


You're right, I'll reduce it. There are a few unrelated changes that could be done after. I'll have to get back to you regarding the "without this change".



================
Comment at: include/llvm/Support/Program.h:68
+  Crashed,             // process crashed
+  TimedOut             // process was forcibly terminated
+};
----------------
thakis wrote:
> Do we need so many different failure types? Isn't "Failure" enough?
The API needs at least that many states, that was the goal in the first place - to stop doing 'if's and 'switch'es based on the return value and/or the PID and/or whether there's an ErrorString or not. I'll see if I can simplify.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62347/new/

https://reviews.llvm.org/D62347