[PATCH] D62153: [WebAssembly] Relax signature checking for undefined functions that are not called directly

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

Otherwise LGTM



================
Comment at: lld/wasm/InputFiles.cpp:280
     if (Section.Type == WASM_SEC_CODE) {
+      assert(!CodeSection);
       CodeSection = &Section;
----------------
Since this is a validation of external input, should we use `report_fatal_error` or some equivalent instead of assert?


================
Comment at: lld/wasm/InputFiles.cpp:337
+    if (WasmSym.isDefined()) {
+      // createDefined may fail if the symbol is comdat exclued in which case
+      // we fall back to creating an undefined symbol
----------------
exclued?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62153/new/

https://reviews.llvm.org/D62153