[PATCH] D62359: [dwarfdump] Make recursion affect the parent chain

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp:202
+                                    aliasopt(ChildRecurseDepth));
+static alias ChildRecurseDepthLimitAlias("limit-children",
+                                         desc("Alias for -recurse-depth."),
----------------
To avoid an overproliferation of options, I think I'd be fine with just adding parent-recurse-depth and dropping the limit-* aliases.


================
Comment at: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp:209
+                            "parents of debug info entries."),
+                       cat(DwarfDumpCategory), init(-1U), value_desc("N"));
+static alias
----------------
why do we use -1U here and check for 0 in the code? I suppose this will also work fine, but it's inconsistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62359/new/

https://reviews.llvm.org/D62359