[PATCH] D62311: [LV] Inform about exactly reason of loop illegality

[Hideki Saito via Phabricator via llvm-commits]

hsaito added a comment.

While we are looking at this, I'd like to discuss how to make these things easier. I think there a merit in using a utility function that takes three strings, something along the lines of
the following pseudo code:

  void reportVectorizationFailure(StringRef ORETag, StringRef OREMsg, StringRef DebugMsg) {
        LLVM_DEBUG(dbgs(), concatenate("LV: Not vectorizing: ", DebugMsg));
        ORE->emit(createMissedAnalysis(ORETag), OREMsg);
  }

Should reduce/eliminate the chances of missing ORE/DEBUG message (i.e., one exists but not the other) and less boilerplate typing. This is just a direction check. I'm not asking
@psamolysov to do this as part of this patch. Better be a separate NFC patch if pursuing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62311/new/

https://reviews.llvm.org/D62311