[PATCH] D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files.

Fri May 24 10:28:30 PDT 2019

hintonda added a comment.

In D62353#1516323 <https://reviews.llvm.org/D62353#1516323>, @beanz wrote:

> In D62353#1516322 <https://reviews.llvm.org/D62353#1516322>, @hintonda wrote:
>
> > Btw, where would you want to put them?
>
>
> Pre-monorepo, it would depend on what the bot is building, but with the mono-repo we could just create a new top-level directory to contain them all. Name each file to match the bot config it runs.

Sounds good.

>> Perhaps if they existed, it might be easier to bot owners to use them.
> 
> I think bot owners need to create and maintain them. Today bot owners control what flags they pass to CMake and we shouldn't change that.

I don't disagree, but I could create the files based on what's in the build logs as a starting point.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62353/new/

https://reviews.llvm.org/D62353