[PATCH] D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files.

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 10:17:12 PDT 2019


hintonda added a comment.

In D62353#1516299 <https://reviews.llvm.org/D62353#1516299>, @beanz wrote:

> I have the same concerns as @labath, so we should certainly put it behind a flag.
>
> I'm also not sure that this is how I would want to handle bot reproducibility. I've been advocating for years that we should migrate bots to using CMake cache files for configurations so that the bot configurations are stored in-tree. @sqlbyme liked that idea, but we never really got any progress on that front. It would be great if we made cache-based configuration a requirement for all bots on lab.llvm.org.


That's a good idea.  Btw, where would you want to put them?  Perhaps if they existed, it might be easier to bot owners to use them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62353/new/

https://reviews.llvm.org/D62353





More information about the llvm-commits mailing list