[PATCH] D62400: [ARM] additionally check for ARM::INLINEASM_BR w/ ARM::INLINEASM

[Peter Smith via Phabricator via llvm-commits]

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

Code change looks good to me. All the places that ARM::INLINE_ASM are mentioned now take into account ARM::INLINEASM_BR.

Would it be possible to try and write a test case that fails without it? I'm thinking of something like:

  extern int other(int *v);
  
  void func(void) {
      int val = 0x12345678; // Generate load from constant pool entry
      other(&val);
  }

In theory if there are enough asm goto before the end of the function (constant pool goes at the end by default) then this should trigger the problem. I wouldn't want to hold up the overall asm-goto effort just for the sake of a test case though so I've marked as approved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62400/new/

https://reviews.llvm.org/D62400