[PATCH] D62353: [cmake] Add new LLVM_CACHE_VARIABLES variable to contains all variables passed to cmake on the commandline or in cache files.

[Don Hinton via Phabricator via llvm-commits]

hintonda marked an inline comment as done.
hintonda added inline comments.


================
Comment at: llvm/CMakeLists.txt:4
+# Generate a list of variables passed to cmake and save the list in
+# the cache.  This list could be used to figure out what should when
+# building host tools for cross-compiles.
----------------
ilya-biryukov wrote:
> NIT: are we missing a part of the phrase? `what should when`
Yes, thanks: s/what should when/what should be passed when/

However, as @labath mentioned, this method won't be reliable when cmake is rerun with different variables/values.  I can test help text in a lot of cases, but that's not 100% either.

So, I'll continue to use this in my local external test project and see if I can add something like this to cmake itself -- assuming people find this useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62353/new/

https://reviews.llvm.org/D62353