[PATCH] D61940: [DebugInfo] Don't always extend variable locations when the reg location is unchanging

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 05:49:30 PDT 2019


jmorse marked 2 inline comments as done.
jmorse added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:277
+          // If this is a register def operand, it may end a debug value
+          // range. Ignore frame-register defs in the epilogue, we expect
+          // debuggers to understand that stack-locations are destroyed on
----------------
bjope wrote:
> Comment here is related to D62314 (that is a child). Maybe D62314 should be a parent instead (unless that complicates things even more for you)?
I'll roll the FrameDestroy comment into the child patch, it should be simpler (IMO).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61940/new/

https://reviews.llvm.org/D61940





More information about the llvm-commits mailing list