[PATCH] D62383: [AArch64][SVE2] Asm: support SVE2 Floating Point Pairwise Group

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes added inline comments.


================
Comment at: test/MC/AArch64/SVE2/faddp-diagnostics.s:36
+// --------------------------------------------------------------------------//
+// Predicate not in restricted predicate range
+
----------------
chill wrote:
> Also `p0/z` is invalid predicate, e.g.:
> 
> ```
> faddp z0.h, p0/z, z0.h, z1.h
> // CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand
> ```
> etc.
> 
I can add a test for that before merging. Managed to miss this for quite a few of the predicate instructions it seems. I have a patch downstream that improves the SVE predicate tests also as similar cases are missing there, I'll get that up after the SVE2 stuff is in.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62383/new/

https://reviews.llvm.org/D62383