[PATCH] D61600: [DebugInfo] More precise variable range for stack locations

Nikola Prica via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 07:41:57 PDT 2019


NikolaPrica updated this revision to Diff 201236.
NikolaPrica added a comment.

- Represent DbgVariable's single value representation by DebugLocEntry::Value insted of representing it with MachineInstr. Such representation will allow us to produce fragment single value representation (for now it is not supported).
- Update DwarfDebug::buildLocationList to check if produced list has single entry that is valid throughout whole variable's scope.

If this seems as a proper way, I suppose that we can make DebugLoc::Value now as a separate class ValueLoc or ValueLocation? Such refactor could go as a separate NFC patch if it is fine?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61600/new/

https://reviews.llvm.org/D61600

Files:
  lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
  lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  lib/CodeGen/AsmPrinter/DwarfUnit.h
  test/DebugInfo/MIR/X86/dbg-stack-value-range.mir
  test/DebugInfo/X86/fission-ranges.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61600.201236.patch
Type: text/x-patch
Size: 32851 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190524/7a52be13/attachment.bin>


More information about the llvm-commits mailing list