[PATCH] D62317: [llvm-objcopy] - Strip undefined symbols if they are no longer referenced following --only-section

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 24 07:41:54 PDT 2019


grimar added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/ELFObjcopy.cpp:419
 
+    // We want to remove the undefined symbols if the source of reference,
+    // like relocation section was stripped.
----------------
jhenderson wrote:
> jhenderson wrote:
> > jhenderson wrote:
> > > remove the undefined -> remove undefined
> > > the source of reference -like relocation section was stripped > all references have been stripped
> > Apparently I failed at typing here:
> > 
> > remove the undefined -> remove undefined
> > the source of reference, like relocation section was stripped -> all references have been stripped
> This comment is still outstanding.
Oops, sorry I missed this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62317/new/

https://reviews.llvm.org/D62317





More information about the llvm-commits mailing list