[PATCH] D62317: [llvm-objcopy] - Strip undefined symbols if they are no longer referenced following --only-section

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/strip-undefined.test:22
+    Type:         SHT_PROGBITS
+    Flags:        [ SHF_ALLOC, SHF_EXECINSTR ]
+  - Name:         .rela.text1
----------------
You shouldn't need these flags either.


================
Comment at: test/tools/llvm-objcopy/ELF/strip-undefined.test:56-57
+Sections:
+  - Name:         .keep_me
+    Type:         SHT_PROGBITS
+Symbols:
----------------
Nit: remove some of the spacing here.


================
Comment at: tools/llvm-objcopy/ELF/ELFObjcopy.cpp:419
 
+    // We want to remove the undefined symbols if the source of reference,
+    // like relocation section was stripped.
----------------
jhenderson wrote:
> jhenderson wrote:
> > remove the undefined -> remove undefined
> > the source of reference -like relocation section was stripped > all references have been stripped
> Apparently I failed at typing here:
> 
> remove the undefined -> remove undefined
> the source of reference, like relocation section was stripped -> all references have been stripped
This comment is still outstanding.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62317/new/

https://reviews.llvm.org/D62317