[PATCH] D62317: [llvm-objcopy] - Strip undefined symbols if they are no longer referenced following --only-section

Fri May 24 07:27:18 PDT 2019

jhenderson added a comment.

In D62317#1515921 <https://reviews.llvm.org/D62317#1515921>, @grimar wrote:

> Is there anything else you think worth to check?

Nope, what you've done seems fine to me. Please just address my inline comments. Note: I am away from the end of work today, for a week. I'm happy for somebody else to approve if my points are addressed.

================
Comment at: test/tools/llvm-objcopy/ELF/only-section-strip-undefined.test:1
+## Here we want to check that llvm-objcopy removes an undefined symbol
+## if all references to it have been stripped.
----------------
jhenderson wrote:
> Maybe worth removing "only-section" from the test title, as I think it would make sense for other options to fall under this test too.
Since this looks to be only for -j behaviour, don't do this after all.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62317/new/

https://reviews.llvm.org/D62317